-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Journeys In-App Plugin #6
Conversation
e155fd7
to
2d560d7
Compare
packages/browser/src/plugins/in-app-plugin/__tests__/index.test.ts
Outdated
Show resolved
Hide resolved
packages/browser/src/plugins/in-app-plugin/__tests__/index.test.ts
Outdated
Show resolved
Hide resolved
packages/browser/src/plugins/in-app-plugin/__tests__/index.test.ts
Outdated
Show resolved
Hide resolved
packages/browser/src/plugins/in-app-plugin/__tests__/index.test.ts
Outdated
Show resolved
Hide resolved
_eventTarget.addEventListener(event, settings?.events as EventListenerOrEventListenerObject); | ||
}); | ||
['messageShown', 'messageDismissed', 'messageError'].forEach((event) => { | ||
Gist.events.on(event, (message: any) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the gist sdk have the equivalent of an "unload" function? (to deregister these events)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We discussed this offline, Gist isn't actually using event handlers, just an array of callback functions to call. So we think this is ok.
Add
Customer.io In-App Plugin
integration, can be loaded via snippet:Or bundled in an app: